Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Tomcat Base64 util #1294

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

nagyesta
Copy link
Owner

Issue: #1293

Description

  • Removes explicit dependency on Tomcat's Base64 implementation
  • Adds new tests to verify that the encoding/decoding works

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Removes explicit dependency on Tomcat's Base64 implementation
- Adds new tests to verify that the encoding/decoding works

Resolves #1293
{patch}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta added the enhancement New feature or request label Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (e538cc5) to head (db84006).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1294   +/-   ##
=========================================
  Coverage     98.89%   98.89%           
- Complexity     2030     2032    +2     
=========================================
  Files           239      239           
  Lines          4963     4965    +2     
  Branches        196      196           
=========================================
+ Hits           4908     4910    +2     
  Misses           42       42           
  Partials         13       13           
Flag Coverage Δ
app 99.37% <100.00%> (+<0.01%) ⬆️
client 94.00% <ø> (ø)
testcontainers 96.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit e15a9fb into main Dec 28, 2024
14 checks passed
@nagyesta nagyesta deleted the feature/1293-stop-using-tomcat-base64 branch December 28, 2024 21:24
@nagyesta nagyesta self-assigned this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant