Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Testcontainers Module #1288

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #1285

Description

  • Adds new endpoints serving the default keystore and keystore password
  • Adds new methods to the Testcontainers module to obtain the keystore and password
  • Adds new test cases to cover new functionality
  • Skips PR labeling from forks

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Adds new endpoints serving the default keystore and keystore password
- Adds new methods to the Testcontainers module to obtain the keystore and password
- Adds new test cases to cover new functionality
- Skips PR labeling from forks

Resolves #1285
{minor}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta self-assigned this Dec 25, 2024
@nagyesta nagyesta added the enhancement New feature or request label Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.89%. Comparing base (8728523) to head (e4bd94a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...wkeyvault/testcontainers/LowkeyVaultContainer.java 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1288      +/-   ##
============================================
- Coverage     98.96%   98.89%   -0.08%     
- Complexity     2024     2030       +6     
============================================
  Files           239      239              
  Lines          4936     4963      +27     
  Branches        194      196       +2     
============================================
+ Hits           4885     4908      +23     
- Misses           38       42       +4     
  Partials         13       13              
Flag Coverage Δ
app 99.36% <100.00%> (+<0.01%) ⬆️
client 94.00% <ø> (ø)
testcontainers 96.03% <78.94%> (-1.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit d0f902e into main Dec 25, 2024
13 of 14 checks passed
@nagyesta nagyesta deleted the feature/1285-improve-testcontainers-module branch December 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant