Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Elliptic Curve key sometimes provides invalid values #1025

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #1024

Description

  • Normalizes EC key X and Y parameters by removing extra leading 0 which is only responsible for indicating that the BigInteger is positive

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Normalises EC key X and Y parameters by removing extra leading 0 which is only responsible for indicating that the BigInteger is positive

Updates #1024
{patch}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta self-assigned this Jun 14, 2024
@nagyesta nagyesta added the bug Something isn't working label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (a4b2fcd) to head (f2088ac).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1025   +/-   ##
=========================================
  Coverage     98.96%   98.96%           
- Complexity     2017     2019    +2     
=========================================
  Files           239      239           
  Lines          4926     4931    +5     
  Branches        192      193    +1     
=========================================
+ Hits           4875     4880    +5     
  Misses           38       38           
  Partials         13       13           
Flag Coverage Δ
app 99.36% <100.00%> (+<0.01%) ⬆️
client 94.09% <ø> (ø)
testcontainers 97.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit 7d19cde into main Jun 14, 2024
13 checks passed
@nagyesta nagyesta deleted the bugfix/1024-elliptic-curve-generator branch June 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant