Inconsistency in created vaults when Vault names is passed along to Lowkey Vault

[Xor-el]

Describe the bug

while working on this, I noticed a weird inconsistency.
An image would explain it better.

by default, vaults are created on 127.0.0.1:8443 and localhost:8443, however if I add a vault name when building the container (let's say our vault name is demo, the new vault is only created on demo.localhost:8443. I expected that the new vault is also created on demo.127.0.0.1:8443 for consistency purposes as is the case when no vault names are passed.

To reproduce

Steps to reproduce the behavior:

1. pass vault names via env when starting up Lowkey Vault

Expected behavior

vaults should be created on both 127.0.0.1 and localhost when custom vault names are passed.

Actual behavior

vaults is only created on localhost when custom vault names are passed.

The command you used

If applicable, add screenshots to help explain your problem.

A minimal project that can be used to reproduce the issue

If applicable. Please do NOT share sensitive information.

Environment

• OS: [e.g. Windows]
• Version: [e.g. 2.6.15]
• Java version [e.g. 17.0.13]

Additional context

Add any other context about the problem here.

[nagyesta]

Hi @Xor-el ,
thank you for reporting this issue!
The behaviour you have noticed is actually as intended, please see the documentation here.
The reason for doing it this way, is because the command line argument you are using is only adding extra vaults with the predefined format and is not registering vaults (as subdomains) for each of the four default vaults.

Speaking of subdomains: you might have noticed, that the address demo.127.0.0.1 looks a bit odd compared to demo.localhost. That is because the 127.0.0.1 is an IP address, while localhost is a DNS address (although one with a special meaning). I think it would be rather odd to use a subdomain of an IP address, therefore the demo.127.0.0.1 is not something we should use. The whole point would be, that in case someone wants to, they can add an extra host to their hosts file and route to the container if they wants to. This is why the default vaults and the ones following the predefined *.localhost pattern are covered by the self-signed certificate we are using and the *.127.0.0.1 would not be.

Also, in case anyone is unhappy with how these vaults can be accessed (I mean unhappy with their names), they can use the alias feature to do so.

Does that make sense?

[Xor-el]

Thanks for the detailed explanation, well understood.