Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide LowKey Vault Test Container Package/Module for DotNet #1313

Open
Xor-el opened this issue Jan 13, 2025 · 3 comments
Open

Provide LowKey Vault Test Container Package/Module for DotNet #1313

Xor-el opened this issue Jan 13, 2025 · 3 comments
Assignees
Labels
community requested Issues requested by our community enhancement New feature or request

Comments

@Xor-el
Copy link

Xor-el commented Jan 13, 2025

Is your feature request related to a problem? Please describe.

It's currently cumbersome to perform integration tests for services that depend on Azure Key Vault. Although we can use LowKey Vault as a test double, the process requires manually starting the Docker image. This manual step disrupts the workflow and does not integrate seamlessly with our testing pipeline.

Describe the solution you'd like

A dedicated LowKey Test Container Package/Module for .NET that automates the setup and teardown of the LowKey Vault Docker container as part of the test lifecycle, simplifying integration testing for Azure Key Vault dependencies.

Describe alternatives you've considered

Manually starting the LowKey Vault Docker container prior to running tests, which is inefficient and prone to errors.

@Xor-el Xor-el added the enhancement New feature or request label Jan 13, 2025
@nagyesta nagyesta self-assigned this Jan 13, 2025
@nagyesta nagyesta moved this from Ideas to Todo for next increment in Lowkey Vault Roadmap Jan 13, 2025
@nagyesta
Copy link
Owner

Hi @Xor-el ,
thank you for reporting this issue and thank you for using Lowkey Vault!
This was a long term plan already for me to have better support for Testcontainers for other languages.

I cannot promise that I will succeed because I am not a .Net developer. As you might imagine, it will be a challenge for sure to accomplish this, but I will try to look into it and see what I can do. I think it would be best to implement this module in Testcontainers. As I see you have created an issue there as well: testcontainers/testcontainers-dotnet#1334

Please feel free to track these tickets for updates...

Thank you!

@nagyesta nagyesta added the community requested Issues requested by our community label Jan 13, 2025
@Xor-el
Copy link
Author

Xor-el commented Jan 13, 2025

@nagyesta Thanks for the feedback. I also agree that it would be better suited to implement this in TestContainers like you mentioned.
I would take some time to see how the containers are implemented and see if it is something I can contribute.
Thanks once again.

@nagyesta
Copy link
Owner

Thank you @Xor-el ! I am sure you have already found it, but just in case you didn't, this is the most interesting class of the Java Testcontainers module: https://github.com/nagyesta/lowkey-vault/blob/main/lowkey-vault-testcontainers/src/main/java/com/github/nagyesta/lowkeyvault/testcontainers/LowkeyVaultContainer.java
Probably it can be useful as an example even if it needs to be ported.

Also, please feel free to reach out in case you are not sure how it works/should work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community requested Issues requested by our community enhancement New feature or request
Projects
Status: Todo for next increment
Development

No branches or pull requests

2 participants