Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Madelyn Olson <[email protected]>
Co-authored-by: Ping Xie <[email protected]>
Signed-off-by: naglera <[email protected]>
  • Loading branch information
3 people authored Jul 16, 2024
1 parent dda1600 commit 1d4e151
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/unit/auth.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ start_server {tags {"auth_binary_password external:skip"}} {
test "primaryauth test with binary password dualchan = $dualchan" {
$master config set requirepass "abc\x00def"
$master config set dual-channel-replication-enabled $dualchan
# Configure the replica with masterauth
# Configure the replica with primaryauth
set loglines [count_log_lines 0]
$slave config set primaryauth "abc"
$slave config set dual-channel-replication-enabled $dualchan
Expand Down
2 changes: 1 addition & 1 deletion valkey.conf
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ repl-diskless-sync-max-replicas 0
repl-diskless-load disabled

# This dual channel replication sync feature optimizes the full synchronization process
# between a primary its replicas. When enabled, it reduces both memory and CPU load
# between a primary and its replicas. When enabled, it reduces both memory and CPU load
# on the primary server.
#
# How it works:
Expand Down

0 comments on commit 1d4e151

Please sign in to comment.