Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow markdown-it as a peerDependency in version ^11.0.0 as well #32

Merged

Conversation

peschee
Copy link
Contributor

@peschee peschee commented Jul 8, 2020

Fixes #31 by allowing to have markdown-it in version ^10.0.0 or ^11.0.0.

@coveralls
Copy link

coveralls commented Jul 8, 2020

Pull Request Test Coverage Report for Build 59

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 97.938%

Totals Coverage Status
Change from base Build 53: 0.03%
Covered Lines: 50
Relevant Lines: 51

💛 - Coveralls

Copy link
Owner

@nagaozen nagaozen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using peerDependency with markdown-it has proven to be a bad idea. Though the project clearly states that it follows semver, major bumps are common without any API breaking changes. It's better for us to just remove the peerDependency from package.json

@peschee
Copy link
Contributor Author

peschee commented Jul 11, 2020

@nagaozen I have removed the markdown-it peer dependency entry.

@nagaozen nagaozen merged commit 958dfe4 into nagaozen:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with markdown-it@^11.0.0
3 participants