add hint of previous object when duplicate detection fails #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whenever naemon encounters a 'Error: Duplicate definition found for' it will now print the location of the previous object definition as well to make debugging easier. While on it, rework xodtemplate_add_object_property() a bit and clean up code. Instead of setting a result, simply return early with the error. There is no cleanup at the end or something like that. Also cleanup the double use of the result variable which was used for the result but also for determing if there is a value set or not. Signed-off-by: Sven Nierlein <[email protected]>
currently naemon silently ignores invalid bool values. For ex.:
register_object yes
does not result in an error but the int value of "yes" is still 0, so the
object won't be registered.
This change adds boolean validation and prints out an error in case the
value is not either 0 or 1.
|
adding and adopting #478 here since they had conflicts which are resolved with this PR |
for some attributes the parser set a flag. This has to be done before returning from the bool parser.
nook24
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenever naemon encounters a 'Error: Duplicate definition found for' it will now print the location of the previous object definition as well to make debugging easier.
While on it, rework xodtemplate_add_object_property() a bit and clean up code. Instead of setting a result, simply return early with the error. There is no cleanup at the end or something like that. Also cleanup the double use of the result variable which was used for the result but also for determing if there is a value set or not.