优化longPulling err时delay、防止日志瞬间写满 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #92 +/- ##
===========================================
+ Coverage 72.00% 72.19% +0.18%
===========================================
Files 15 15
Lines 1186 1194 +8
===========================================
+ Hits 854 862 +8
Misses 265 265
Partials 67 67
Continue to review full report at Codecov.
|
lzp0412
reviewed
Jul 30, 2020
| changedConfigs := strings.Split(changed, "%01") | ||
| for _, config := range changedConfigs { | ||
| attrs := strings.Split(config, "%02") | ||
| if len(attrs) >= 2 { | ||
| if value, ok := cacheMap.Get(utils.GetConfigCacheKey(attrs[0], attrs[1], tenant)); ok { | ||
| cData := value.(cacheData) | ||
| if content, err := client.getConfigInner(vo.ConfigParam{ | ||
| if content, err2 := client.getConfigInner(vo.ConfigParam{ |
There was a problem hiding this comment.
为什么要使用err2这个变量？我觉得不需要引入这个变量
There was a problem hiding this comment.
client.getConfigInner如果出错（比如group或dataid错误），日志还是会大量报错（config_client.go 429行)
lzp0412
reviewed
Jul 30, 2020
| const perTaskConfigSize = 3000 | ||
| const ( | ||
| perTaskConfigSize = 3000 | ||
| executorErrDelay = 20 * time.Second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.