Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] fixup config listen cache empty #697

Conversation

robynron
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (65e2c9d) 29.67% compared to head (059ce86) 29.93%.

❗ Current head 059ce86 differs from pull request most recent head 4618db0. Consider uploading reports for the commit 4618db0 to get more accurate results

Files Patch % Lines
clients/config_client/config_client.go 64.70% 5 Missing and 1 partial ⚠️
vo/config_param.go 66.66% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   29.67%   29.93%   +0.26%     
==========================================
  Files          40       41       +1     
  Lines        3144     3153       +9     
==========================================
+ Hits          933      944      +11     
+ Misses       2139     2137       -2     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robynron
Copy link
Contributor Author

fixup #694 #692

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 8677a56 into nacos-group:master Dec 14, 2023
2 checks passed
@robynron robynron deleted the dev/chasu/fixup_config_listen_cache_empty branch December 15, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants