Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] fix up encryption logger: replace logging when init() with createConfigClient #690

Merged

Conversation

robynron
Copy link
Contributor

@robynron robynron commented Dec 1, 2023

No description provided.

@robynron
Copy link
Contributor Author

robynron commented Dec 1, 2023

fix #687

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (355c2fd) 29.79% compared to head (2e475ba) 29.64%.

❗ Current head 2e475ba differs from pull request most recent head 8646fe2. Consider uploading reports for the commit 8646fe2 to get more accurate results

Files Patch % Lines
clients/config_client/config_client.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   29.79%   29.64%   -0.15%     
==========================================
  Files          40       40              
  Lines        3145     3147       +2     
==========================================
- Hits          937      933       -4     
- Misses       2137     2142       +5     
- Partials       71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin0325 binbin0325 merged commit 5fedf57 into nacos-group:master Dec 5, 2023
2 checks passed
@robynron robynron deleted the dev/chasu/fixup_logger_level_2 branch December 15, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants