Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request-Module header when requesting endpoint #685

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (28188c7) 29.65% compared to head (0d4b123) 29.79%.

❗ Current head 0d4b123 differs from pull request most recent head 76bf38d. Consider uploading reports for the commit 76bf38d to get more accurate results

Files Patch % Lines
common/nacos_server/nacos_server.go 33.33% 4 Missing ⚠️
clients/naming_client/naming_proxy_delegate.go 77.77% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   29.65%   29.79%   +0.13%     
==========================================
  Files          40       40              
  Lines        3136     3145       +9     
==========================================
+ Hits          930      937       +7     
- Misses       2136     2137       +1     
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin0325 binbin0325 merged commit 355c2fd into nacos-group:master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants