-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop endpoint #673
Develop endpoint #673
Conversation
go func() { | ||
for { | ||
select { | ||
case <-ctx.Done(): | ||
return | ||
default: | ||
time.Sleep(time.Duration(1) * time.Second) | ||
server.refreshServerSrvIfNeed() | ||
time.Sleep(time.Duration(10) * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里建议用个case timer做这个事情
default不要了
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 30.03% 29.90% -0.13%
==========================================
Files 40 40
Lines 3070 3093 +23
==========================================
+ Hits 922 925 +3
- Misses 2081 2100 +19
- Partials 67 68 +1
☔ View full report in Codecov by Sentry. |
* support endpoint params * support endpoint context path
support user define full address url.
1.add endpointContextPath, clusterName,endpointQueryParams to replace fix "/nacos/serverlist"
fix rpc client reconnect to server twice on startup.
optimize http get method params concat logic.