Develop endpoint #673
Merged
Develop endpoint #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robynron
reviewed
Oct 27, 2023
| go func() { | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| time.Sleep(time.Duration(1) * time.Second) | ||
| server.refreshServerSrvIfNeed() | ||
| time.Sleep(time.Duration(10) * time.Second) |
There was a problem hiding this comment.
这里建议用个case timer做这个事情
default不要了
binbin0325
approved these changes
Oct 30, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 30.03% 29.90% -0.13%
==========================================
Files 40 40
Lines 3070 3093 +23
==========================================
+ Hits 922 925 +3
- Misses 2081 2100 +19
- Partials 67 68 +1
☔ View full report in Codecov by Sentry. |
yesAnd92
pushed a commit
to yesAnd92/nacos-sdk-go
that referenced
this pull request
Nov 3, 2023
* support endpoint params * support endpoint context path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support user define full address url.
1.add endpointContextPath, clusterName,endpointQueryParams to replace fix "/nacos/serverlist"
fix rpc client reconnect to server twice on startup.
optimize http get method params concat logic.