[feature] support aes-128 & aes-256 encryption #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ored in Nacos are success in test
|
|
binbin0325
reviewed
Oct 25, 2023
| @@ -19,12 +19,15 @@ package config_client | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/alibabacloud-go/tea/tea" | |||
| @@ -0,0 +1,56 @@ | |||
| package encoding | |||
There was a problem hiding this comment.
New File add open source license
common/encoding/encryption.go
Outdated
| return "" | ||
| } | ||
| var startPos, endPos int | ||
| resRunes := make([]rune, 0) |
There was a problem hiding this comment.
slice advised to set the initial capacity to 8
common/encryption/kms_client.go
Outdated
|
|
||
| func InitDefaultKmsV1ClientWithAccessKey(regionId, ak, sk string) (*KmsClient, error) { | ||
| var rErr error | ||
| if GetDefaultKmsClient() == nil { |
There was a problem hiding this comment.
if there is too much nesting, reverse is recommended
common/encryption/kms_client.go
Outdated
|
|
||
| func (kmsClient *KmsClient) Decrypt(cipherContent string) (string, error) { | ||
| request := kms.CreateDecryptRequest() | ||
| request.Method = "POST" |
There was a problem hiding this comment.
"POST" replace http.MethodPost
binbin0325
approved these changes
Nov 8, 2023
KomachiSion
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.