Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config center support for disable local cache #565

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

wangdongyun
Copy link
Contributor

@wangdongyun wangdongyun commented Jan 31, 2023

关联的issue

  1. sdk 支持禁用本地缓存 [config] sdk 支持禁用本地缓存 #563
  2. sdk 在远程nacos不可用情况下,允许降级本地配置 [config] 在nacos故障场景下,client 无法初始化,降级本地配置失败 #564
  3. 初始化 connection的时候,传AppName(同java-sdk 一致),服务端方便统计

clients/config_client/config_client.go Outdated Show resolved Hide resolved
clients/config_client/config_client.go Outdated Show resolved Hide resolved
common/constant/const.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Base: 31.26% // Head: 31.03% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (5529615) compared to base (3b038b4).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 5529615 differs from pull request most recent head 77ed42b. Consider uploading reports for the commit 77ed42b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   31.26%   31.03%   -0.24%     
==========================================
  Files          40       40              
  Lines        2987     3003      +16     
==========================================
- Hits          934      932       -2     
- Misses       1988     2004      +16     
- Partials       65       67       +2     
Impacted Files Coverage Δ
clients/config_client/config_client.go 37.83% <0.00%> (-0.92%) ⬇️
clients/config_client/config_proxy.go 5.30% <0.00%> (-0.30%) ⬇️
common/constant/client_config_options.go 80.51% <0.00%> (-3.27%) ⬇️
common/nacos_server/nacos_server.go 16.98% <0.00%> (ø)
.../naming_client/naming_cache/service_info_holder.go 25.26% <0.00%> (-2.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 63f4c7b into nacos-group:master Feb 3, 2023
@binbin0325 binbin0325 changed the title [conf] 配置中心关于本地文件缓存问题 config center support for disable local cache Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants