Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the logger data race #170

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix the logger data race #170

merged 1 commit into from
Jan 14, 2021

Conversation

legenove
Copy link
Contributor

@legenove legenove commented Dec 25, 2020

fix logger data race

Fixes #148
@sanxun0325

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #170 (057308d) into master (0647923) will increase coverage by 0.54%.
The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   59.01%   59.55%   +0.54%     
==========================================
  Files          22       22              
  Lines        1447     1454       +7     
==========================================
+ Hits          854      866      +12     
+ Misses        521      517       -4     
+ Partials       72       71       -1     
Impacted Files Coverage Δ
common/logger/logging.go 0.00% <0.00%> (ø)
common/logger/logger.go 92.85% <90.90%> (+9.18%) ⬆️
clients/naming_client/host_reator.go 56.79% <0.00%> (-2.47%) ⬇️
clients/config_client/config_client.go 59.44% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0647923...057308d. Read the comment docs.

@legenove legenove changed the title fix the logger race and all client use a single logger fix the logger data race Dec 28, 2020
@legenove
Copy link
Contributor Author

legenove commented Jan 6, 2021

优先只解决data race问题,帮忙review下~ @sanxun0325

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lzp0412 lzp0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325
Copy link
Member

Thanks for your contribution and look forward to more

@binbin0325 binbin0325 merged commit fbe2919 into nacos-group:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create multiple clients and the logger will be overwritten
4 participants