-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init client's params change to ...options #167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 57.80% 58.67% +0.86%
==========================================
Files 20 22 +2
Lines 1384 1447 +63
==========================================
+ Hits 800 849 +49
- Misses 513 525 +12
- Partials 71 73 +2
Continue to review full report at Codecov.
|
@sanxun0325 主体部分已经完成了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加使用options创建出来的serverConfig以及clientConfig 调用 CreateConfigClient的UT,也许会更好
现在搞定了 |
@mark4z 可以在文档添加下新用法的使用说明,然后可以在example里增加下示例 |
是修改还是增加 |
增加,可以体现出既支持options也支持原有方式 。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #154