Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get empty server list from endpoint #162

Merged
merged 6 commits into from
Dec 8, 2020
Merged

fix: get empty server list from endpoint #162

merged 6 commits into from
Dec 8, 2020

Conversation

lzp0412
Copy link
Collaborator

@lzp0412 lzp0412 commented Dec 8, 2020

fix: get empty server list from endpoint

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #162 (5a038dd) into master (fb45465) will decrease coverage by 9.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   66.22%   57.04%   -9.18%     
==========================================
  Files          19       20       +1     
  Lines        1199     1383     +184     
==========================================
- Hits          794      789       -5     
- Misses        334      521     +187     
- Partials       71       73       +2     
Impacted Files Coverage Δ
clients/config_client/config_proxy.go 76.38% <ø> (ø)
clients/naming_client/naming_proxy.go 54.62% <ø> (ø)
common/nacos_server/nacos_server.go 1.67% <0.00%> (ø)
clients/naming_client/host_reator.go 49.38% <0.00%> (-9.88%) ⬇️
util/common.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb45465...5a038dd. Read the comment docs.

@lzp0412 lzp0412 merged commit fab32c8 into master Dec 8, 2020
@lzp0412 lzp0412 deleted the debug-prom branch December 8, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants