Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #123]Fix config client cachemap initialization logic #125

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

binbin0325
Copy link
Member

@binbin0325 binbin0325 commented Oct 3, 2020

fix cachemap had multiple initializations, causes the cacheData to be emptied.#123

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@170bb4e). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage          ?   66.77%           
=========================================
  Files             ?       19           
  Lines             ?     1192           
  Branches          ?        0           
=========================================
  Hits              ?      796           
  Misses            ?      326           
  Partials          ?       70           
Impacted Files Coverage Δ
clients/config_client/config_client.go 59.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170bb4e...ab22764. Read the comment docs.

Copy link
Collaborator

@lzp0412 lzp0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 6c8cd18 into nacos-group:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants