-
Notifications
You must be signed in to change notification settings - Fork 22
Added networking hack for CNI namespaced veth pairs #35
Conversation
Signed-off-by: Brandon Lum <[email protected]>
Signed-off-by: Brandon Lum <[email protected]>
@@ -18,9 +18,13 @@ | |||
# PERFORMANCE OF THIS SOFTWARE. | |||
|
|||
BIN_PATH=/usr/local/bin/ | |||
BIN_PATH2=/opt/runnc/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this path needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since runnc
is the only thing that the user is going to use, i was moving runnc-cont
and nabla-run
into a directory where the user would not be able to directly call it. As discussed, will add this as a comment.
} else if inK8s { | ||
// The tap device will get the IP assigned to the Docker | ||
// container veth pair. | ||
ip, gw, mask, err = network.CreateTapInterfaceDocker(tapName, "eth0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment (a XXX) mentioning the error you get when using macvtaps. It's kind of mysterious to me why this is working and the macvtap not when using k8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will do!
Signed-off-by: Brandon Lum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Added modifications to work with networking of k8s CNI plugin using network namespace for now.
Signed-off-by: Brandon Lum [email protected]