Revert Module Providers Registration to Previous Version #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this affect the loading of the modules that you recently introduced? |
|
no, in my os, boot time not changed. has same times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request reverts the module providers registration process to the previous version. The changes were initially introduced in #1879 by me.
After reviewing the codebase and encountering new issues, it became clear that this modification introduced several breaking changes. Some projects that rely on disabling modules and registering them with a single file have experienced issues due to these updates.
Additionally, this change caused the
bootandregisterevents for modules to stop firing. This issue wasn't caught earlier because the current tests for modules do not cover this part. A separate pull request will add tests for this section to prevent similar issues in the future.