ci: Make pinning e2e test work locally (no-changelog) #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
requested review from
alexgrozav and
OlegIvaniv
and removed request for
alexgrozav
n8n-assistant
bot
added
n8n team
Signed-off-by: Oleg Ivaniv <[email protected]>
OlegIvaniv
approved these changes
Jul 5, 2024
2 flaky tests on run #5807 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9954 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
jeanpaul
pushed a commit
that referenced
this pull request
Jul 11, 2024
Signed-off-by: Oleg Ivaniv <[email protected]> Co-authored-by: Oleg Ivaniv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current e2e setup depends on the custom max pinned-data size to be set at compile time, which only works if the person testing it remembers to set the env variable.
This PR changes the setup to let us customize the max max pinned-data size at runtime instead, like we do for
preventNodeViewBeforeUnload.This unblocks #9696
Review / Merge checklist