Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix frontend project roles #9901

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(editor): Fix frontend project roles #9901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions packages/editor-ui/src/stores/roles.store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
import { useRolesStore } from '@/stores/roles.store';
import * as rolesApi from '@/api/roles.api';
import { createPinia, setActivePinia } from 'pinia';

let rolesStore: ReturnType<typeof useRolesStore>;

describe('roles store', () => {
beforeEach(() => {
setActivePinia(createPinia());
rolesStore = useRolesStore();
});

it('should use project roles defined in the frontend in correct order', async () => {
vi.spyOn(rolesApi, 'getRoles').mockResolvedValue({
global: [],
credential: [],
workflow: [],
project: [
{
name: 'Project Admin',
role: 'project:admin',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'workflow:move',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'credential:move',
'project:list',
'project:read',
'project:update',
'project:delete',
],
licensed: true,
},
{
name: 'Project Owner',
role: 'project:personalOwner',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'workflow:share',
'workflow:move',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'credential:share',
'credential:move',
'project:list',
'project:read',
],
licensed: true,
},
{
name: 'Project Editor',
role: 'project:editor',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'project:list',
'project:read',
],
licensed: true,
},
{
name: 'Project Viewer',
role: 'project:viewer',
scopes: [
'credential:list',
'credential:read',
'project:list',
'project:read',
'workflow:list',
'workflow:read',
],
licensed: true,
},
],
});
await rolesStore.fetchRoles();
expect(rolesStore.processedProjectRoles.map(({ role }) => role)).toEqual([
'project:editor',
'project:admin',
]);
});
});
4 changes: 2 additions & 2 deletions packages/editor-ui/src/stores/roles.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ export const useRolesStore = defineStore('roles', () => {

const processedProjectRoles = computed<RoleMap['project']>(() =>
roles.value.project
.filter((role) => projectRoleOrderMap.value.has(role.role))
.sort(
(a, b) =>
(projectRoleOrderMap.value.get(a.role) ?? 0) -
(projectRoleOrderMap.value.get(b.role) ?? 0),
)
.filter((role) => role.role !== 'project:personalOwner'),
),
);

const processedCredentialRoles = computed<RoleMap['credential']>(() =>
Expand Down
Loading