-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Centralize scaling mode (no-changelog) #9835
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8c4ba29
Initial setup
ivov 2af8654
Remove outdated `job.id` being `undefined` comments
ivov c62dd67
Update comment
ivov e7226d9
Rename arg for accuracy
ivov 5d31ea7
Fix reference
ivov 5874d16
Refactor to scaling mode
ivov 0178ac1
Update breaking changes doc
ivov f705749
Add `UnsupportedRedisVersionError`
ivov 4a93183
Back to `bull`
ivov 8fac1f9
Merge master, fix conflicts
ivov 40ad161
Fix misresolved conflicts
ivov 8243c3a
Update shutdown
ivov 2e943c4
Update lockfile
ivov 618476b
Extract `JobProcessor`
ivov cdb9f63
Remove lockfile from diff
ivov 6962cb8
Merge branch 'master' into pay-1658-upgrade-to-bullmq
ivov 5a89544
Move running jobs to `JobProcessor`
ivov c94b656
Separate listeners
ivov 7060cd4
Use job processor directly in worker
ivov 28ae137
Merge branch 'master' into pay-1658-upgrade-to-bullmq
ivov 57cd9f7
Refactor to `ScalingService`
ivov a3c7620
Merge branch 'master' into pay-1658-upgrade-to-bullmq
ivov 77c32e4
Rename `Consumer` to `Processor`
ivov cc18f5c
Fix import
ivov 5c2d77e
Add `executionId` to `Job finished running` log
ivov 362b3dd
Rename `RunningJobProps` to `RunningJob`
ivov 211ab03
Fix stopping tests
ivov 294efb4
Merge master, fix conflicts
ivov a0be4b6
Merge master, fix conflicts
ivov 7e76a27
Apply feedback
ivov 1225b9c
Better typing
ivov 1792e17
Rename to `JobProcessor`
ivov 83b14e2
Rename labels as well
ivov 30017e6
Merge master, fix conflicts
ivov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we can get rid of all the watchdog functionality