Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix ARM custom images (no-changelog) #9821

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 20, 2024

Summary

pnpm rebuild doesn't seem to work with pnpm deploy.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ENG-118/fix-arm64-custom-images

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy requested a review from OlegIvaniv June 20, 2024 14:17
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 20, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jun 20, 2024

1 failed and 1 flaky tests on run #5614 ↗︎

1 366 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 7d6fda8477
Status: Failed Duration: 04:19 💡
Started: Jun 20, 2024 2:38 PM Ended: Jun 20, 2024 2:42 PM
Failed  10-undo-redo.cy.ts • 1 failed test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video
Failed  32-node-io-filter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  39-import-workflow.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  2106-ADO-pinned-data-execution-preview.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-if-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 15 specs in Cypress Cloud.

Flakiness  e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video

Review all test suite changes for PR #9821 ↗︎

@netroy netroy merged commit b131d75 into master Jun 20, 2024
24 of 27 checks passed
@netroy netroy deleted the fix-ARM-custom-images-ENG-118 branch June 20, 2024 14:44
longnz added a commit to AcclaroInc/workflow-automation that referenced this pull request Jun 21, 2024
* 'master' of github.com:n8n-io/n8n: (380 commits)
  feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832)
  refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829)
  refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827)
  fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078)
  🚀 Release 1.47.0 (n8n-io#9826)
  ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825)
  docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188)
  feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138)
  ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822)
  fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801)
  ci: Fix ARM custom images (no-changelog) (n8n-io#9821)
  fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815)
  fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811)
  fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649)
  fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587)
  fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292)
  fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608)
  refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757)
  refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305)
  fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889)
  ...
longnz added a commit to AcclaroInc/workflow-automation that referenced this pull request Jun 21, 2024
* n8n-io-master: (380 commits)
  feat(Anthropic Chat Model Node): Add support for Claude 3.5 Sonnet (n8n-io#9832)
  refactor(core): Remove inferral of execution status (no-changelog) (n8n-io#9829)
  refactor(core): Log denials from subworkflow caller policy (no-changelog) (n8n-io#9827)
  fix(Zulip Node): Fix a typo preventing some messages from updating (n8n-io#7078)
  🚀 Release 1.47.0 (n8n-io#9826)
  ci: Fix repository url for provenance checks (no-changelog) (n8n-io#9825)
  docs: Update docs links in the HTTP node (no-changelog) (n8n-io#9188)
  feat(Pipedrive Node): Add sort field for get all persons (n8n-io#8138)
  ci: Add opencontainer image spec labels to the release Dockerfile (no-changelog) (n8n-io#9822)
  fix(core): Upgrade `ws` to address CVE-2024-37890 (n8n-io#9801)
  ci: Fix ARM custom images (no-changelog) (n8n-io#9821)
  fix: Get workflow not returning home project and shared projects (no-changelog) (n8n-io#9815)
  fix(AWS SES Node): Fix issue with email aliases not working for sending from or sending to (n8n-io#9811)
  fix(Google Sheets Node): Check for column names changes before upsert, append, update (n8n-io#9649)
  fix(MongoDB Node): Correct typo in MongoDbProperties (no-changelog) (n8n-io#9587)
  fix(editor): Console error in ActionsMode when searching for action and pressing enter (no-changelog) (n8n-io#9292)
  fix(Airtable Node): Make multipleRecordLinks editable in fields (n8n-io#9608)
  refactor(editor): Refactor code editors to composition API (no-changelog) (n8n-io#9757)
  refactor: Correct spelling mistakes (no-changelog) (n8n-io#9305)
  fix(editor): Align all cell contents to the top in RunDataTable (no-changelog) (n8n-io#3889)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants