feat(core): Use WebCrypto to generate all random numbers and strings #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
previously approved these changes
Jun 17, 2024
packages/cli/test/integration/credentials/credentials.api.test.ts
Outdated
Show resolved
Hide resolved
|
✅ No visual regressions found. |
netroy
force-pushed
the
SEC-51-cryptographically-safe-integers
branch
from
892d62a to
99402df
Compare
netroy
changed the title
netroy
commented
Jun 17, 2024
Comment on lines
-153
to
-164
| test('PATCH /me/password should fail due to missing MFA token', async () => { | ||
| const { user, rawPassword } = await createUserWithMfaEnabled(); | ||
|
|
||
| const newPassword = randomPassword(); | ||
|
|
||
| await testServer | ||
| .authAgentFor(user) | ||
| .patch('/me/password') | ||
| .send({ currentPassword: rawPassword, newPassword }) | ||
| .expect(400); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@RicardoE105 Can you please confirm if this test was invalid?
The 400 is coming from the new password not passing the password policy, and I don't see any MFA checks in any of the /me endpoints.
There was a problem hiding this comment.
Just saw this message. Having a look
There was a problem hiding this comment.
Looks like this was mistake. But this raises the question: Should we ask for MFA token if the user tries to update the password when it's logged in? 🤔
There was a problem hiding this comment.
Should we ask for MFA token if the user tries to update the password
netroy
force-pushed
the
SEC-51-cryptographically-safe-integers
branch
from
2fdd17e to
ad07c6b
Compare
despairblue
reviewed
Jun 18, 2024
despairblue
requested changes
Jun 19, 2024
…cally-safe-integers
…to tests" This reverts commit 7e7e659.
despairblue
previously approved these changes
Jun 19, 2024
|
|
2 flaky tests on run #5586 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9786 ↗︎
despairblue
approved these changes
Jun 19, 2024
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Math.randomis considered insecure.This PR replaces it with WebCrypto based random number and string generators.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SEC-51
Review / Merge checklist