fix(core): Ensure followers do not recover executions from logs #9785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Jun 18, 2024
| ) {} | ||
|
|
||
| /** | ||
| * Recover key properties of a truncated execution using event logs. | ||
| */ | ||
| async recoverFromLogs(executionId: string, messages: EventMessageTypes[]) { | ||
| if (this.orchestrationService.isFollower) return; |
There was a problem hiding this comment.
Would it make sense to move this check to this line instead?
There was a problem hiding this comment.
My reasoning for making the leadership check internal to the service is to prevent someone in future using recoverFromLogs elsewhere and forgetting to account for leadership. This follows the pattern in WaitTracker and PruningService.
netroy
approved these changes
Jun 18, 2024
|
✅ No visual regressions found. |
1 flaky test on run #5546 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9785 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1682