refactor(core): Refactor cli command tests (no-changelog) #9731
Conversation
n8n-assistant
bot
added
core
| @@ -498,7 +498,7 @@ export class Worker extends BaseCommand { | |||
| } | |||
|
|
|||
| // Make sure that the process does not close | |||
| await new Promise(() => {}); | |||
| if (!inTest) await new Promise(() => {}); | |||
There was a problem hiding this comment.
I take it there's no other choice but in general we should avoid sprinkling inTest checks in production code.
There was a problem hiding this comment.
This was "temporary" code that Jan had to add, after I broke this in #5452 .
At some point I hope to fix this properly, until then we need this ugly check 😞
| }); | ||
|
|
||
| afterAll(async () => { | ||
| await testDb.terminate(); |
There was a problem hiding this comment.
Nit - Some testDb calls happen in the suite, some happen here. This dries up tests but might condition us to e.g. forget about testDb.terminate in tests that are not about CLI commands and do not have this convenience? Personally I'd prefer not to switch back and forth to see what the suite is doing. Really minor though.
There was a problem hiding this comment.
yeah, I wasn't happy about that either, and I'm hoping to clean this up even more in the future. I just wanted to get this change in first, so that I can add unit tests for the rest of the commands.
|
✅ No visual regressions found. |
3 flaky tests on run #5547 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9731 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
1 similar comment
|
Got released with |
Summary
extracted out of #9696
Review / Merge checklist