refactor(core): Include logless case in crash recovery (no-changelog) #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Jun 13, 2024
| ); | ||
|
|
||
| const messages = setupMessages(execution.id, workflow.name); | ||
| describe('if messages', () => { |
There was a problem hiding this comment.
From here only added indentation and reworded test names.
n8n-assistant
bot
added
core
krynble
reviewed
Jun 13, 2024
krynble
approved these changes
Jun 13, 2024
3 flaky tests on run #5463 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9725 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9676