test: Use nanoid instead of UUID in e2e tests for wf names (no-changelog) #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. `pnpm test:e2e:all 1-workflows.cy`
We have been adding a random uuid to workflow names in some e2e tests. Cypress is actually pretty slow in typing text to input fields. Since uuid is 36 characters, this adds some delay to our e2e tests. This change shaves some seconds off by using a 12 character long nanoid instead. On my local machine 19-execution suite execution time went from 47.3s to 42.7s (3 test run avg). 1-workflows went from 27.3s to 24.7s.
netroy
reviewed
Jun 12, 2024
5 flaky tests on run #5454 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9717 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
deleted the
test-use-nanoid-instead-of-uuid-in-e2e-tests-for-wf-names
branch
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains 2 changes to e2e test:
pnpm test:e2e:all 1-workflows.cyWe have been adding a random uuid to workflow names in some e2e tests.
Cypress is actually pretty slow in typing text to input fields. Since
uuid is 36 characters, this adds some delay to our e2e tests. This
change shaves some seconds off by using a 12 character long
nanoid instead.
On my local machine 19-execution suite execution time went from 47.3s
to 42.7s (3 test run avg). 1-workflows went from 27.3s to 24.7s.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)