Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add canvas edge toolbar hover show/hide support (no-changelog) #9699

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Jun 11, 2024

Summary

Add canvas edge toolbar show/hide when hovering the edge.

Screen.Recording.2024-06-11.at.14.04.48.mov

Related tickets and issues

https://linear.app/n8n/issue/N8N-7427/hideshow-edge-actions-on-hover

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@alexgrozav alexgrozav self-assigned this Jun 11, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 11, 2024
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jun 11, 2024

2 flaky tests on run #5433 ↗︎

0 365 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 07b0379067
Status: Passed Duration: 05:03 💡
Started: Jun 11, 2024 1:33 PM Ended: Jun 11, 2024 1:38 PM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9699 ↗︎

@alexgrozav alexgrozav merged commit daf85b4 into master Jun 11, 2024
27 checks passed
@alexgrozav alexgrozav deleted the n8n-7427-hideshow-edge-actions-on-hover branch June 11, 2024 16:09
MiloradFilipovic added a commit that referenced this pull request Jun 12, 2024
* master:
  fix(editor): Add back credential type icon (no-changelog) (#9704)
  feat(editor): Add canvas edge toolbar hover show/hide support (no-changelog) (#9699)
  ci: Fix custom docker builds (no-changelog) (#9702)
  test: Fix e2e for projects missing instance owner (no-changelog) (#9703)
  ci: Refactor e2e tests to be less flaky (no-changelog) (#9695)
  feat(editor): Add move resources option to workflows and credentials on (#9654)
  fix: Introduce `HooksService` (#8962)
  fix(editor): Improve large data warning in input/output panel (#9671)
  ci(editor): Enforce type-safety in @n8n/chat builds as well (no-changelog) (#9685)
  fix(editor): Un-skip workflow save test (no-changelog) (#9698)
  refactor(core): Remove more dead code from event bus (no-changelog) (#9697)
  ci: Remove unused WaitTracker mocking (no-changelog) (#9694)
  feat: Update NPS Value Survey (#9638)
  refactor(core): Remove event bus channel (no-changelog) (#9663)
  refactor(core): Remove event bus helpers (no-changelog) (#9690)
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants