fix(editor): Error dropdown in resource locator disappears when search filter is required #9681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
MiloradFilipovic
approved these changes
Jun 10, 2024
|
|
…g-repository-owner-dropdown
MiloradFilipovic
previously approved these changes
Jun 11, 2024
1 flaky test on run #5551 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9681 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
approved these changes
Jun 12, 2024
|
|
…g-repository-owner-dropdown
alexgrozav
approved these changes
Jun 17, 2024
|
✅ All Cypress E2E specs passed |
…g-repository-owner-dropdown
alexgrozav
approved these changes
Jun 18, 2024
|
✅ No visual regressions found. |
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1206-github-trigger-bug-when-searching-repository-owner-dropdown
branch
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…h filter is required (n8n-io#9681)
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…h filter is required (n8n-io#9681)
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dropdown in resource locator disappears on error when search filter is required
Can be tested with the Github Trigger. Should be tested with:
Related tickets and issues
https://linear.app/n8n/issue/NODE-1206/github-trigger-bug-when-searching-repository-owner-dropdown
Review / Merge checklist
(no-changelog)otherwise. (conventions)