feat(editor): Add isEmpty on DateTime, add is empty to all types in filter component #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
MiloradFilipovic
previously approved these changes
Jun 6, 2024
| { left: 15, expected: false }, | ||
| { left: -15.4, expected: false }, | ||
| { left: NaN, expected: true }, | ||
| { left: null, expected: true }, |
There was a problem hiding this comment.
Are these tests needed if the option is hidded for numbers? Also should we add tests for other data types?
There was a problem hiding this comment.
It's hidden in the expressions because of the bug, this test is about the filter component. But will add tests for the types that are missing (DateTime,boolean)
|
|
2 flaky tests on run #5358 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9645 ↗︎
MiloradFilipovic
approved these changes
Jun 6, 2024
|
✅ All Cypress E2E specs passed |
…ressions-and-filter
MiloradFilipovic
approved these changes
Jun 7, 2024
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1375-make-isempty-more-visible-in-expressions-and-filter
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isEmptyto Date/DateTime autocompleteis empty/is not emptyto all types in filter componentRelated tickets and issues
https://linear.app/n8n/issue/NODE-1375/make-isempty-more-visible-in-expressions-and-filter-component
Review / Merge checklist
(no-changelog)otherwise. (conventions)