-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for dark mode node icons and colors #9412
Conversation
…dark-mode-icons-on-dark-mode' of github.com:n8n-io/n8n into node-1337-dark-mode-icons-on-dark-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
I didn't go through every single icon but from general browsing through the node creator and interacting with the canvas it all LGTM 👌
✅ All Cypress E2E specs passed |
1 flaky test on run #5319 ↗︎
Details:
cypress/e2e/5-ndv.cy.ts • 1 flaky test
Review all test suite changes for PR #9412 ↗︎ |
* master: feat: Initial Dev Containers setup (no-changelog) (#8951) feat: Add support for dark mode node icons and colors (#9412) fix(Gotify Node): Fix issue with self signed certificates not working (#9647) refactor(core): Support writing tests in `cli/src` (no-changelog) (#9646) fix(n8n Form Trigger Node): Error if Respond to Webhook and respond node not in workflow (#9641)
Co-authored-by: Giulio Andreini <[email protected]>
Got released with |
This MR removes icon files, which are still referenced in some nodes:
|
Summary
Related tickets and issues
https://linear.app/n8n/issue/NODE-1337/dark-mode-icons-on-dark-mode
Review / Merge checklist
(no-changelog)
otherwise. (conventions)