Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for dark mode node icons and colors #9412

Merged
merged 23 commits into from
Jun 6, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented May 15, 2024

Summary

  • Add optional dark mode icons for nodes
  • Add node icon color presets for core nodes
// How to define a dark mode icon (backwards compatible)
icon: { light: 'file:googleSheets.svg', dark: 'file:googleSheetsDark.svg' }
icon: 'file:googleSheets.svg'

// How to define icon color from preset (has priority over `defaults.color`)
iconColor: 'blue'
image

Related tickets and issues

https://linear.app/n8n/issue/NODE-1337/dark-mode-icons-on-dark-mode

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels May 15, 2024
@elsmr elsmr marked this pull request as ready for review May 15, 2024 14:23
@elsmr elsmr changed the title feat: Add dark support for dark mode icons and colors feat: Add support for dark mode node icons and colors May 15, 2024
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
I didn't go through every single icon but from general browsing through the node creator and interacting with the canvas it all LGTM 👌

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jun 5, 2024

1 flaky test on run #5319 ↗︎

0 356 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 4d1cff8ba7
Status: Passed Duration: 04:57 💡
Started: Jun 5, 2024 11:08 AM Ended: Jun 5, 2024 11:13 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9412 ↗︎

@elsmr elsmr merged commit 600013a into master Jun 6, 2024
28 checks passed
@elsmr elsmr deleted the node-1337-dark-mode-icons-on-dark-mode branch June 6, 2024 11:34
MiloradFilipovic added a commit that referenced this pull request Jun 6, 2024
* master:
  feat: Initial Dev Containers setup (no-changelog) (#8951)
  feat: Add support for dark mode node icons and colors (#9412)
  fix(Gotify Node): Fix issue with self signed certificates not working (#9647)
  refactor(core): Support writing tests in `cli/src` (no-changelog) (#9646)
  fix(n8n Form Trigger Node): Error if Respond to Webhook and respond node not in workflow (#9641)
RicardoE105 pushed a commit that referenced this pull request Jun 9, 2024
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with [email protected]

@marzn
Copy link
Contributor

marzn commented Jun 24, 2024

This MR removes icon files, which are still referenced in some nodes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants