refactor(core): Use consistent CSRF state validation across oAuth controllers #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
previously approved these changes
May 23, 2024
2 failed and 1 flaky tests on run #5118 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9104 ↗︎
|
✅ All Cypress E2E specs passed |
despairblue
reviewed
May 23, 2024
packages/cli/src/controllers/oauth/oAuth2Credential.controller.ts
Outdated
Show resolved
Hide resolved
packages/cli/test/unit/controllers/oauth/oAuth1Credential.controller.test.ts
Show resolved
Hide resolved
packages/cli/test/unit/controllers/oauth/oAuth1Credential.controller.test.ts
Show resolved
Hide resolved
netroy
commented
May 23, 2024
packages/cli/src/controllers/oauth/oAuth2Credential.controller.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Danny Martini <[email protected]>
despairblue
approved these changes
May 23, 2024
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 24, 2024
* master: refactor(core): Use consistent CSRF state validation across oAuth controllers (#9104) feat(core): Print the name of the migration that cannot be reverted when using `n8n db:revert` (#9473) fix(editor): Hard load after logout to reset stores (no-changelog) (#9500) refactor(core): Stop reporting `EAUTH` error codes to Sentry (no-changelog) (#9496) fix(core): Upgrade sheetjs to address CVE-2024-22363 (#9498) refactor: Remove skipped tests (no-changelog) (#9497) feat(editor): Add initial code for NodeView and Canvas rewrite (no-changelog) (#9135) fix(editor): Show input panel with not connected message (#9495) fix(editor): Prevent XSS in node-issues tooltip (#9490) # Conflicts: # pnpm-lock.yaml
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a CSRF state on oAuth2 flows to prevent
credentialIdfrom being tampered with.This PR updates the oAuth1 flows to reuse the same code to ensure the same level of safety across all oAuth flows.
Review / Merge checklist