Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Hover and active states not showing in execution list on dark mode #9002

Merged
merged 3 commits into from
Mar 29, 2024
Merged

fix(editor): Hover and active states not showing in execution list on dark mode #9002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e62ce9e
Hover and active not showing in execution list on dark mode
RicardoE105 Mar 28, 2024
490abac
Add new --execution-card-background-hover variable
RicardoE105 Mar 29, 2024
51c1a91
Grouped css tokens.
gandreini Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/design-system/src/css/_tokens.dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@
// Notification
--color-notification-background: var(--prim-gray-740);

// Execution card
--execution-card-background-hover: var(--color-foreground-base);

// NDV
--color-run-data-background: var(--prim-gray-800);
--color-ndv-droppable-parameter: var(--prim-color-primary);
Expand Down
1 change: 1 addition & 0 deletions packages/design-system/src/css/_tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@
--execution-card-border-waiting: var(--prim-color-secondary-tint-300);
--execution-card-border-running: var(--prim-color-alt-b-tint-250);
--execution-card-border-unknown: var(--prim-gray-120);
--execution-card-background-hover: var(--color-foreground-light);

// NDV
--color-run-data-background: var(--color-background-base);
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/ExecutionsView/ExecutionCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export default defineComponent({
&:hover,
&.active {
.executionLink {
background-color: var(--color-foreground-light);
background-color: var(--execution-card-background-hover);
}
}

Expand Down
Loading