feat(core)!: Set the secure flag on issued cookies
#8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
tomi
previously approved these changes
Mar 5, 2024
|
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
N8N-7246-secure-only-cookie
branch
from
12cd613 to
b1f0546
Compare
netroy
changed the title
secure flag on issued cookiessecure flag on issued cookies
|
Updated |
tomi
approved these changes
Mar 5, 2024
| @@ -15,6 +15,7 @@ if (inE2ETests) { | |||
| process.env.N8N_LOG_LEVEL = 'silent'; | |||
| process.env.N8N_PUBLIC_API_DISABLED = 'true'; | |||
| process.env.SKIP_STATISTICS_EVENTS = 'true'; | |||
| process.env.N8N_SECURE_COOKIE = 'false'; | |||
There was a problem hiding this comment.
Maybe we could set it to true in tests so it corresponds the most common config? Or leave it out so the default value gets tested
There was a problem hiding this comment.
we unfortunately can't to do that right now because superagent doesn't handle secure cookies, which breaks every integration test that updates the cookie in response.
|
✅ All Cypress E2E specs passed |
netroy
added a commit
that referenced
this pull request
Mar 5, 2024
netroy
added a commit
that referenced
this pull request
Mar 6, 2024
|
Got released with |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently n8n does not set
secureflag on issues cookies. This means that if an instance is reachable over http, it could be vulnerable to MITM attacks.N8N-7246
Review / Merge checklist