Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Update auth related typings (no-changelog) #8686

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 20, 2024

This PR deletes some duplicate and outdated typings related to authenticated requests.

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 20, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@netroy netroy requested a review from tomi February 23, 2024 13:43
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 23, 2024

2 flaky tests on run #4202 ↗︎

0 339 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: f70d5a3563
Status: Passed Duration: 03:40 💡
Started: Feb 23, 2024 1:58 PM Ended: Feb 23, 2024 2:02 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video

Review all test suite changes for PR #8686 ↗︎

@netroy netroy merged commit 35fb710 into master Feb 23, 2024
28 checks passed
@netroy netroy deleted the refactor-auth-typings branch February 23, 2024 14:08
MiloradFilipovic added a commit that referenced this pull request Feb 26, 2024
* master: (63 commits)
  fix(editor): Fix various typecheck issues (no-changelog) (#8739)
  feat: SQL agent improvements (#8709)
  fix(Postgres Trigger Node): `closeFunction` errors should not prevent a workflow from being deactivated (#8738)
  feat: Add support for Ollama embeddings API (#8732)
  fix(editor): Remove NDVSubConnections component console.log (no-changelog) (#8737)
  fix(editor): Hide previous execution data for sub-nodes in debug mode if it has execution error (#8710)
  feat: Add env variables to support exposing `/workflows/demo` route and `/nodes.json` route (#8506)
  refactor(core): Update auth related typings (no-changelog) (#8686)
  docs: Update docker-compose.yml example to Postgres 16 and update initialization script (#8486)
  fix(editor): Update Filter component state when value is updated (#8684)
  feat(editor): AI Floating Nodes (#8703)
  fix(core): Fix pairedItem issue with partial manual executions (#8575)
  fix: Fix execution error when using AI chain nodes with non-chat model (#8724)
  feat(AI Agent Node): Allow use of Azure Chat model for OpenAI Functions agent (#8725)
  ci: Upgrade `ip` to address CVE-2023-42282 (no-changelog) (#8704)
  fix(core): Ensure `maxRedirects` is used for any http request defining it (#8706)
  fix(Trello Node): Remove GET request body (#8715)
  fix(editor): Do not break NDV for version-less nodes (#8714)
  feat(editor): Retrieve previous chat message on arrow-up (#8696)
  fix(Default Data Loader Node): Fix binary data loader in s3 mode (#8626)
  ...
@janober
Copy link
Member

janober commented Feb 28, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants