fix(OpenAI Node): Always show jsonOutput toggle for OpenAI message operation (no-changelog) #8651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
approved these changes
Feb 16, 2024
2 flaky tests on run #4125 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Execution > should test manual workflow stop |
Test Replay
Screenshots
Video
|
|
38-custom-template-repository.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| In-app templates repository > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8651 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Feb 16, 2024
…eration (no-changelog) (#8651)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the recent Open AI node overhaul, we've added a toggle to support JSON response. But this toggle was only enabled if
gpt-3.5-turbo-1106orgpt-4-1106-previewmodel was selected. This would prevent the user from enabling the JSON response for the latest models(gpt-3.5-turbo-0125,gpt-4-turbo-preview, etc.). So, instead, we always show this toggle with a hint that it's supported only with the newer models.Review / Merge checklist
(no-changelog)otherwise. (conventions)