fix(FTP Node): Fix issue with connections not closing properly #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
maspio
approved these changes
Feb 13, 2024
3 flaky tests on run #4087 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
38-custom-template-repository.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| In-app templates repository > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8619 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
reviewed
Feb 14, 2024
Comment on lines
450
to
+457
| } catch (error) { | ||
| await ftp.end(); | ||
| return { | ||
| status: 'Error', | ||
| message: error.message, | ||
| }; | ||
| } | ||
| await ftp.end(); |
There was a problem hiding this comment.
This is a perfect case for finally:
} catch (error) {
return {
status: 'Error',
message: error.message,
};
} finally {
await ftp.end();
}
netroy
pushed a commit
that referenced
this pull request
Feb 14, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were failing to close FTP / SFTP connections on node errors and credential tests.
Related tickets and issues
https://community.n8n.io/t/sftp-ftp-node-doesnt-close-connection/32581