fix(Execute Workflow Node): Passing the workflow that is supposed to be executed as a paramter #8614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
1 flaky test on run #4085 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| In-app templates repository > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8614 ↗︎
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-1362-execute-workflow-node-with-source-parameter-does-not-work
branch
netroy
reviewed
Feb 14, 2024
| @@ -29,7 +29,8 @@ export async function getWorkflowInfo(this: IExecuteFunctions, source: string, i | |||
| workflowInfo.code = jsonParse(workflowJson); | |||
| } else if (source === 'parameter') { | |||
| // Read workflow from parameter | |||
| workflowInfo.code = this.getNodeParameter('workflowJson', itemIndex) as IWorkflowBase; | |||
| const workflowJson = this.getNodeParameter('workflowJson', itemIndex) as string; | |||
There was a problem hiding this comment.
A better fix for this would be to make sure that getNodeParameter does jsonParse when the parameter type is json. either that, or we get rid of type: 'json', and convert such parameters to be strings.
Created a backlog ticket for this: ENG-101
netroy
pushed a commit
that referenced
this pull request
Feb 14, 2024
…be executed as a paramter (#8614)
Merged
|
Got released with |
Merged
despairblue
added a commit
that referenced
this pull request
Feb 16, 2024
…be executed as a paramter (#8614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression introduced with 216ec07, e.g. in version 1.23.0.
I'd love to write a test for this too, but the node is not testable right now with the unit test framework. First this function here has to be implemented:
n8n/packages/nodes-base/test/nodes/Helpers.ts
Line 177 in 32281d1
I've tried, but I stopped after a while, not to loose too much time on it. Maybe the nodes team can take a look at adding a test for this.
Related tickets and issues
https://linear.app/n8n/issue/PAY-1362/execute-workflow-node-with-source-parameter-does-not-work-anymore
Review / Merge checklist
(no-changelog)otherwise. (conventions)