Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FTP Node): Fix issue with paireditems not always working #8613

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Feb 12, 2024

Summary

Fixes an issue that prevented paired items from being availble, Will check other nodes for the same issue shortly.

Related tickets and issues

https://community.n8n.io/t/issue-backlinking/40061

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 12, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 12, 2024

2 flaky tests on run #4082 ↗︎

0 343 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: a225545bfb
Status: Passed Duration: 03:25 💡
Started: Feb 12, 2024 3:54 PM Ended: Feb 12, 2024 3:58 PM
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #8613 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit d38a822 into master Feb 12, 2024
28 checks passed
@Joffcom Joffcom deleted the c/40061 branch February 12, 2024 16:06
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@janober
Copy link
Member

janober commented Feb 15, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants