Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix resolving of expressions of deeply nested sub-nodes #8612

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

  • Move the getParentMainInputNode method to WorkflowProxy so it can be reused on the backend
  • Update the expression guard in WorkflowDataProxy to check for sub-node's root node to determine if expression is valid

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 12, 2024
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test, just checked the code, it seems ok.

Copy link

cypress bot commented Feb 14, 2024

1 flaky test on run #4093 ↗︎

0 343 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: 6b8dbc2e84
Status: Passed Duration: 03:21 💡
Started: Feb 14, 2024 9:37 AM Ended: Feb 14, 2024 9:40 AM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8612 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit f527430 into master Feb 14, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the pay-1264-ai-nodes-possible-paired-items-issue branch February 14, 2024 09:42
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@janober
Copy link
Member

janober commented Feb 15, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants