Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(editor): Refactor workflowHelpers mixin to composable (no-changelog) #8600

Merged
merged 3 commits into from
Feb 12, 2024
Merged

refactor(editor): Refactor workflowHelpers mixin to composable (no-changelog) #8600

merged 3 commits into from
Feb 12, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Feb 9, 2024 •
edited by mutdmour
Loading

Summary

  • Refactor workflowHelpers mixin to composable & replace usage

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 9, 2024
@cypress Cypress
Copy link

cypress bot commented Feb 9, 2024 •
edited
Loading

2 flaky tests on run #4078 ↗︎

0 341 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: 361a488a03
Status: Passed Duration: 03:56 💡
Started: Feb 12, 2024 9:35 AM Ended: Feb 12, 2024 9:39 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  32-node-io-filter.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Node IO Filter > should filter input/output data separately Test Replay Screenshots Video

Review all test suite changes for PR #8600 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 510bf89 into master Feb 12, 2024
30 checks passed
@OlegIvaniv OlegIvaniv deleted the n8n-7141-workflowhelpers branch February 12, 2024 09:45
@janober
Copy link
Member

janober commented Feb 15, 2024

Got released with [email protected]

cstuncsik pushed a commit that referenced this pull request Feb 17, 2024
@OlegIvaniv @cstuncsik
refactor(editor): Refactor workflowHelpers mixin to composable (no-ch…
4e0958c 
…angelog) (#8600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @mutdmour