fix(HTTP Request Node): Handle special characters in pagination expressions + improve hint text

packages/@n8n/nodes-langchain/nodes/trigger/ChatTrigger/ChatTrigger.node.ts

@@ -352,10 +352,10 @@ export class ChatTrigger implements INodeType {
 				await validateAuth(this);
 			} catch (error) {
 				if (error) {
-					res.writeHead(error.responseCode as number, {
+					res.writeHead((error as IDataObject).responseCode as number, {
 						'www-authenticate': 'Basic realm="Webhook"',
 					});
-					res.end(error.message as string);
+					res.end((error as IDataObject).message as string);
 					return { noWebhookResponse: true };
 				}
 				throw error;

packages/core/src/NodeExecuteFunctions.ts

@@ -197,6 +197,17 @@ const createFormDataObject = (data: Record<string, unknown>) => {
 	return formData;
 };
 
+const validateUrl = (url?: string): boolean => {
+	if (!url) return false;
+
+	try {
+		new URL(url);
+		return true;
+	} catch (error) {
+		return false;
+	}
+};
+
 function searchForHeader(config: AxiosRequestConfig, headerName: string) {
 	if (config.headers === undefined) {
 		return undefined;
@@ -1240,7 +1251,10 @@ function applyPaginationRequestData(
 	requestData: OptionsWithUri,
 	paginationRequestData: PaginationOptions['request'],
 ): OptionsWithUri {
-	const preparedPaginationData: Partial<OptionsWithUri> = { ...paginationRequestData };
+	const preparedPaginationData: Partial<OptionsWithUri> = {
+		...paginationRequestData,
+		uri: paginationRequestData.url,
+	};
 
 	if ('formData' in requestData) {
 		preparedPaginationData.formData = paginationRequestData.body;
@@ -2885,6 +2899,14 @@ const getRequestHelperFunctions = (
 
 				const tempRequestOptions = applyPaginationRequestData(requestOptions, paginateRequestData);
 
+				if (!validateUrl(tempRequestOptions.uri as string)) {
+					throw new NodeOperationError(node, `'${paginateRequestData.url}' is not a valid URL.`, {
+						itemIndex,
+						runIndex,
+						type: 'invalid_url',
+					});
+				}
+
 				if (credentialsType) {
 					tempResponseData = await this.helpers.requestWithAuthentication.call(
 						this,

packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorInput.vue

@@ -3,23 +3,22 @@
 </template>
 
 <script lang="ts">
-import { defineComponent } from 'vue';
-import type { PropType } from 'vue';
-import { mapStores } from 'pinia';
-import { EditorView, keymap } from '@codemirror/view';
-import { Compartment, EditorState, Prec } from '@codemirror/state';
-import { history, redo, undo } from '@codemirror/commands';
 import { acceptCompletion, autocompletion, completionStatus } from '@codemirror/autocomplete';
+import { history, redo, undo } from '@codemirror/commands';
+import { Compartment, EditorState, Prec } from '@codemirror/state';
+import { EditorView, keymap } from '@codemirror/view';
+import type { PropType } from 'vue';
+import { defineComponent } from 'vue';
 
-import { useNDVStore } from '@/stores/ndv.store';
-import { workflowHelpers } from '@/mixins/workflowHelpers';
+import { completionManager } from '@/mixins/completionManager';
 import { expressionManager } from '@/mixins/expressionManager';
-import { highlighter } from '@/plugins/codemirror/resolvableHighlighter';
+import { workflowHelpers } from '@/mixins/workflowHelpers';
 import { expressionInputHandler } from '@/plugins/codemirror/inputHandlers/expression.inputHandler';
-import { inputTheme } from './theme';
 import { n8nLang } from '@/plugins/codemirror/n8nLang';
-import { completionManager } from '@/mixins/completionManager';
+import { highlighter } from '@/plugins/codemirror/resolvableHighlighter';
+import { isEqual } from 'lodash-es';
 import type { IDataObject } from 'n8n-workflow';
+import { inputTheme } from './theme';
 
 const editableConf = new Compartment();
 
@@ -69,26 +68,18 @@ export default defineComponent({
 				},
 			});
 		},
-		ndvInputData() {
-			this.editor?.dispatch({
-				changes: {
-					from: 0,
-					to: this.editor.state.doc.length,
-					insert: this.modelValue,
-				},
-			});
+		displayableSegments(segments, newSegments) {
+			if (isEqual(segments, newSegments)) return;
+
+			highlighter.removeColor(this.editor, this.plaintextSegments);
+			highlighter.addColor(this.editor, this.resolvableSegments);
 
-			setTimeout(() => {
-				this.editor?.contentDOM.blur();
+			this.$emit('change', {
+				value: this.unresolvedExpression,
+				segments: this.displayableSegments,
 			});
 		},
 	},
-	computed: {
-		...mapStores(useNDVStore),
-		ndvInputData(): object {
-			return this.ndvStore.ndvInputData;
-		},
-	},
 	mounted() {
 		const extensions = [
 			n8nLang(),
@@ -126,19 +117,11 @@ export default defineComponent({
 				// Force segments value update by keeping track of editor state
 				this.editorState = this.editor.state;
 
-				highlighter.removeColor(this.editor, this.plaintextSegments);
-				highlighter.addColor(this.editor, this.resolvableSegments);
-
 				setTimeout(() => {
 					try {
 						this.trackCompletion(viewUpdate, this.path);
 					} catch {}
 				});
-
-				this.$emit('change', {
-					value: this.unresolvedExpression,
-					segments: this.displayableSegments,
-				});
 			}),
 		];
 
@@ -149,14 +132,10 @@ export default defineComponent({
 				extensions,
 			}),
 		});
+
 		this.editorState = this.editor.state;
 
 		highlighter.addColor(this.editor, this.resolvableSegments);
-
-		this.$emit('change', {
-			value: this.unresolvedExpression,
-			segments: this.displayableSegments,
-		});
 	},
 	beforeUnmount() {
 		this.editor?.destroy();

packages/editor-ui/src/components/Node.vue

@@ -728,7 +728,8 @@ export default defineComponent({
 			this.$emit('removeNode', this.data.name);
 		},
 
-		toggleDisableNode() {
+		toggleDisableNode(event: MouseEvent) {
+			(event.currentTarget as HTMLButtonElement).blur();
 			this.$telemetry.track('User clicked node hover button', {
 				node_type: this.data.type,
 				button_name: 'disable',

packages/editor-ui/src/mixins/workflowHelpers.ts

@@ -212,7 +212,7 @@ export function resolveParameter(
 		// in pagination expressions
 		additionalKeys.$response = get(
 			executionData,
-			`data.executionData.contextData['node:${activeNode.name}'].response`,
+			['data', 'executionData', 'contextData', `node:${activeNode.name}`, 'response'],
 			{},
 		);
 	}

packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts

@@ -988,7 +988,7 @@ export class HttpRequestV3 implements INodeType {
 											},
 											default: '',
 											description:
-												'Should evaluate to true when pagination is complete. More info.',
+												'Should evaluate to the URL of the next page. <a href="https://docs.n8n.io/integrations/builtin/core-nodes/n8n-nodes-base.httprequest/#pagination" target="_blank">More info</a>.',
 										},
 										{
 											displayName: 'Parameters',
@@ -1112,7 +1112,7 @@ export class HttpRequestV3 implements INodeType {
 											},
 											default: '',
 											description:
-												'Should evaluate to true when pagination is complete. More info.',
+												'Should evaluate to true when pagination is complete. <a href="https://docs.n8n.io/integrations/builtin/core-nodes/n8n-nodes-base.httprequest/#pagination" target="_blank">More info</a>.',
 										},
 										{
 											displayName: 'Limit Pages Fetched',
@@ -1704,13 +1704,25 @@ export class HttpRequestV3 implements INodeType {
 					paginationData.binaryResult = true;
 				}
 
-				const requestPromise = this.helpers.requestWithAuthenticationPaginated.call(
-					this,
-					requestOptions,
-					itemIndex,
-					paginationData,
-					nodeCredentialType ?? genericCredentialType,
-				);
+				const requestPromise = this.helpers.requestWithAuthenticationPaginated
+					.call(
+						this,
+						requestOptions,
+						itemIndex,
+						paginationData,
+						nodeCredentialType ?? genericCredentialType,
+					)
+					.catch((error) => {
+						if (error instanceof NodeOperationError && error.type === 'invalid_url') {
+							const urlParameterName =
+								pagination.paginationMode === 'responseContainsNextURL' ? 'Next URL' : 'URL';
+							throw new NodeOperationError(this.getNode(), error.message, {
+								description: `Make sure the "${urlParameterName}" parameter evaluates to a valid URL.`,
+							});
+						}
+
+						throw error;
+					});
 				requestPromises.push(requestPromise);
 			} else if (authentication === 'genericCredentialType' || authentication === 'none') {
 				if (oAuth1Api) {

packages/workflow/src/RoutingNode.ts

@@ -223,7 +223,7 @@ export class RoutingNode {
 				returnData.push(...responseData);
 			} catch (error) {
 				if (thisArgs !== undefined && thisArgs.continueOnFail()) {
-					returnData.push({ json: {}, error: error as NodeError });
+					returnData.push({ json: {}, error: error as NodeApiError });
 					continue;
 				}
 

packages/workflow/src/errors/node-api.error.ts

@@ -24,6 +24,7 @@ export interface NodeOperationErrorOptions {
 	level?: ReportingOptions['level'];
 	messageMapping?: { [key: string]: string }; // allows to pass custom mapping for error messages scoped to a node
 	functionality?: Functionality;
+	type?: string;
 }
 
 interface NodeApiErrorOptions extends NodeOperationErrorOptions {

packages/workflow/src/errors/node-operation.error.ts

@@ -8,6 +8,8 @@ import { NodeError } from './abstract/node.error';
 export class NodeOperationError extends NodeError {
 	lineNumber: number | undefined;
 
+	type: string | undefined;
+
 	constructor(
 		node: INode,
 		error: Error | string | JsonObject,
@@ -21,6 +23,7 @@ export class NodeOperationError extends NodeError {
 		if (options.message) this.message = options.message;
 		if (options.level) this.level = options.level;
 		if (options.functionality) this.functionality = options.functionality;
+		if (options.type) this.type = options.type;
 		this.description = options.description;
 		this.context.runIndex = options.runIndex;
 		this.context.itemIndex = options.itemIndex;