fix(RSS Feed Trigger Node): Save last item's date instead of last execution date

[sweenu]

Summary

Some RSS feed won't update exactly at the time show on the last item. In order to have a more reliable node, we stop checking for the last time we polled the feed to know which items are new, but instead we store and check the last item's publication date.

Related tickets and issues

Related to #8473.

Review / Merge checklist

• PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.

  A bug is not considered fixed, unless a test is added to prevent it from happening again.
  A feature is not complete without tests.

I saw no tests were present for this node. I didn't add one. I did test the behavior locally, though.

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

@sweenu that looks like it is it, Have you given it a test? It may be worth having something in there to set the lastItemDate to the lastRun if it exists as well so we don't make things worse for existing users.

[sweenu]

Locally, yes, it works as expected. Okay, let me make the modifications.

[sweenu]

@Joffcom Do you still want to populate pollData.lastTimeChecked or do we just check it to make the transition?

[Joffcom]

@sweenu I think we should just use it once to set the new option if it is not empty and if the workflow is not being ran manually. Then we can delete it and we should be all good.

[sweenu]

Done. I tested again with the same workflow and also a brand new one.
I should also probably change the name of startDate. How about dateToCheck?

[Joffcom]

That looks good, I am just creating a docker image and I will leave it running overnight to see if anything odd happens

[sweenu]

I've got no clue what the problem is with the linting, I might need your help:
45:22 error Replace `·` with `⏎↹↹↹` prettier/prettier

I ran pnpm lint -- --fix but it hasn't done anything.

[Joffcom]

@sweenu it wants to you to change it to

const dateToCheck =
	(pollData.lastItemDate as string) || (pollData.lastTimeChecked as string) || now;

I would push the change but you used the master branch instead of making a new one.

[sweenu]

Sorry, bad habit. Thanks for your help. Pushed the fix.

[Joffcom]

The test image seems to be running well so far I have had a couple of posts from Hackernews come through and none of the old events have fired off. I think we will be able to get this merged tomorrow, Fantastic work 🙌🏻

[Joffcom]

Hey @sweenu,

Testing overnight has looked very good and no issues so I think we can get this merged and make this node better for everyone.

[janober]

Got released with [email protected]