Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new 'is empty' and 'is not empty' operators to Filter #8445

Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 25, 2024

Summary

image
  • New operators should work as expected
  • Empty operators in old and new If node should behave the same (use workflow JSON from linear to check)

Related tickets and issues

https://linear.app/n8n/issue/NODE-1072/is-not-empty-operation-missing-from-latest-if-node

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 25, 2024
…is-not-empty-operation-missing-from-latest-if-node
Copy link

cypress bot commented Jan 26, 2024

1 flaky test on run #3915 ↗︎

0 338 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 5eafeaab22
Status: Passed Duration: 03:36 💡
Started: Jan 26, 2024 6:33 AM Ended: Jan 26, 2024 6:37 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8445 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit c21c4b9 into master Jan 26, 2024
28 checks passed
@elsmr elsmr deleted the node-1072-is-not-empty-operation-missing-from-latest-if-node branch January 26, 2024 10:17
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
@janober
Copy link
Member

janober commented Feb 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants