fix(core): Fix update workflow cli command being unable to activate all workflows #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
changed the title
despairblue
changed the title
despairblue
changed the title
despairblue
force-pushed
the
N8N-3763-fix-update-workflow-command
branch
from
6d5b495 to
6173a03
Compare
n8n-assistant
bot
added
core
despairblue
commented
Jan 22, 2024
| await Container.get(WorkflowRepository).deactivateAll(); | ||
| this.logger.info(`${action} all workflows`); | ||
| if (newState) { | ||
| // TODO: Maybe there should be an `updateActiveStateForAll(state)`? |
There was a problem hiding this comment.
Wondering if that makes sense? What do you think?
There was a problem hiding this comment.
Since the existing deactivateAll is only used here, it's fine if we rename it and make it more generic so we can just use a single flag, but either work. The current naming is also very explicit and clear in what it does.
despairblue
force-pushed
the
N8N-3763-fix-update-workflow-command
branch
from
6173a03 to
86e9b97
Compare
can be changed later
krynble
previously approved these changes
Jan 23, 2024
2 flaky tests on run #3872 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8412 ↗︎
|
✅ All Cypress E2E specs passed |
This was referenced Jan 23, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This work is based on #6759, thank you @schroedan for tackling this ❤️
Before this change activating all workflows led to all workflows being deactivated instead:
Now it actually activates them:
This also adds
WorkflowRepository#activateAlland a test for it, as well as a test forWorkflowRepository#deactivateAllRelated tickets and issues
https://linear.app/n8n/issue/PAY-1206/cli-activating-workflows-fails
https://community.n8n.io/t/setting-all-workflows-to-active-not-working/34901
#4753
#6759
Review / Merge checklist
(no-changelog)otherwise. (conventions)