Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Microsoft SQL Node): Prevent MSSQL max parameters error by chunking #8390

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 18, 2024

Summary

With this fix it is possible to insert large datasets in the Microsoft SQL node:

image

Related tickets and issues

https://community.n8n.io/t/microsoft-sql-node-insert-problem-bug/32509
https://linear.app/n8n/issue/NODE-909/mssql-too-many-parameters

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 18, 2024
Copy link

cypress bot commented Jan 19, 2024

Passing run #3830 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: e78eadf9d5
Status: Passed Duration: 03:19 💡
Started: Jan 19, 2024 8:42 AM Ended: Jan 19, 2024 8:46 AM

Review all test suite changes for PR #8390 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 1b0ba2c into master Jan 19, 2024
28 checks passed
@elsmr elsmr deleted the node-909-mssql-too-many-parameters branch January 19, 2024 13:31
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants