-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Discord Node): Remove requirement on message for webhooks #8377
fix(Discord Node): Remove requirement on message for webhooks #8377
Conversation
939cb49
to
7c65364
Compare
@nihaals just looking at this again, If you don't specify a Message what happens? |
You can't trigger the node as the field is required |
@nihaals in that case I am confused, Why would you remove the required option if it is actually required? |
Oh I meant before this patch. The reason it's not required is the same as #8060 (I just forgot to apply the change to webhooks too as I didn't realise they were implemented separately, them not being required is the same for both webhooks and Discord bot messages):
Without this patch it's still not possible to migrate to v2 unless you're able to switch to a bot token (and are unnecessarily forced to) as the change was only applied to bot messages and not also webhook messages. |
Hey @nihaals, Perfect thanks 👍🏻 |
Got released with |
Summary
This adds a missing change to #8060 which affects sending from webhooks.
Review / Merge checklist
(no-changelog)
otherwise. (conventions)